feat: Add support for '.' on qrest path parameter #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aVolpe
force-pushed
the
feature/add_support_for_dot_in_url_param
branch
3 times, most recently
from
4cc9d62
to
3650fc5
Compare
This commit adds support for path parameter that has dots ('.').
The dot is a commonly used path parameter, for example, all the URLs with
filenames have a dot for the extension.
I can't find any reference to support dots in this specification:
https://www.rfc-editor.org/rfc/rfc6570
But in this specification:
https://www.w3.org/Addressing/URL/url-spec.txt
When describing a
[BNF](https://en.wikipedia.org/wiki/Backus%E2%80%93Naur_form), the dot
is in the 'safe' rule, which is part of the 'segment' rule that defines
the 'path' of an URL.
Other use cases are:
* API Versioning: add the API version in the path, this is already
partially supported with the wildcard (v2/*)
* minigl code: the mini account codes are a tree of all the parent
accounts codes separated with a dot.
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
Signed-off-by: Arturo Volpe <avolpe@fintech.works>
aVolpe
force-pushed
the
feature/add_support_for_dot_in_url_param
branch
from
3650fc5
to
3acc7e4
Compare
ar
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for path parameter that has dots ('.').
The dot is a commonly used path parameter, for example, all the URLs with
filenames have a dot for the extension.
I can't find any reference to support dots in this specification:
But in this specification:
When describing a BNF,
the dot is in the 'safe' rule, which is part of the 'segment' rule that
defines the 'path' of an URL.
Other use cases are:
partially supported with the wildcard (v2/*)
accounts codes separated with a dot.
Signed-off-by: Arturo Volpe avolpe@fintech.works