Register the Txn mgr object in the Namergistrar at the end of startservice method instead of the beginning

[mchhil-incomm]

jPOS/jpos/src/main/java/org/jpos/transaction/TransactionManager.java

Lines 125 to 154 in 0e36304

	public void startService () throws Exception {
	NameRegistrar.register(getName(), this);
	recover();
	threads = Collections.synchronizedList(new ArrayList(maxSessions));
	if (tps != null)
	tps.stop();
	tps = new TPS (cfg.getBoolean ("auto-update-tps", true));
	for (int i=0; i<sessions; i++) {
	new Thread(this).start();
	}
	if (psp.rdp (RETRY_QUEUE) != null)
	checkRetryTask();
	if (maxSessions > sessions) {
	loadMonitorExecutor = ConcurrentUtil.newScheduledThreadPoolExecutor();
	loadMonitorExecutor.scheduleAtFixedRate(
	new Thread(() -> {
	int count = getSessionsToStandUp();
	if (count>0) {
	for (int i=0; i<count; i++)
	new Thread(this).start();
	getLog().info("Created " + count + " additional sessions");
	}
	}), 5, 1, TimeUnit.SECONDS)
	;
	}
	if (iisp != isp) {
	new Thread(new InputQueueMonitor()).start();
	}
	}

Ran into this due to a misconfiguration at my end.

A deploy file (say 90) that gets deployed prior to this transaction manager's deploy(say 95) and gets the txn mgr from the nameregistrar and calls the getTPS().intValue() on it and fails with a NPE. My gut feeling is that it got caught during startservice between making it available in the registrar and before the new TPS object is created.

So may be the correct place to put the object in the namerigstrar is at the end of the start service.

[ar]

Good catch, makes perfect sense to register at the end of the method. Will change that right away.