hande plot_network/get interactions more gracefully #259 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpquast
reviewed
Jul 10, 2024
|
Could you please also fix issue #244 within this PR? Not sure if there is by now a newer version than 12. Could you also write the changes and fixes into the |
… into fail_gracefully_259
… into fail_gracefully_259
jpquast
requested changes
Jul 11, 2024
jpquast
requested changes
Jul 12, 2024
R/analyse_functional_network.R
Outdated
Comment on lines
159
to
170
| string_db <- tryCatch( | ||
| { | ||
| STRINGdb$new( | ||
| version = version, | ||
| species = organism_id, # Check on String database to get the right code (E.coli K12: 511145) | ||
| score_threshold = score_threshold, # Cutoff score to consider something an interaction | ||
| input_directory = "" | ||
| ) | ||
| }, | ||
| error = function(e) { | ||
| e$message | ||
| } |
There was a problem hiding this comment.
Can you also catch the warning message here. You don't need to include the resulting message, but just not have it return the warning.
There was a problem hiding this comment.
should we print this part ("A warning occurred during the interaction network analysis: " or not?
:)
There was a problem hiding this comment.
yes looks good like this actually! Thanks! :)
… into fail_gracefully_259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #259
closes #244