Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/stat: fix max call stack size exceeded #679

Merged
merged 1 commit into from
May 13, 2019
Merged

util/stat: fix max call stack size exceeded #679

merged 1 commit into from
May 13, 2019

Conversation

manidlou
Copy link
Collaborator

fixes #678.

  • resolve paths before parsing in util/stat.js
  • add util/stat tests

JPeer264
JPeer264 approved these changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

coveralls commented May 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 83.903% when pulling 72278dc on fix-max-call-stack into a7f303b on master.

@manidlou manidlou self-assigned this May 13, 2019
@manidlou manidlou added the bug label May 13, 2019
JPeer264
JPeer264 approved these changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good :)

@manidlou
Copy link
Collaborator Author

@jprichardson @RyanZim @JPeer264 please let me know if you have any concerns regarding this!

@manidlou
Copy link
Collaborator Author

rebased it. It should be ready now!

@manidlou manidlou mentioned this pull request May 13, 2019
Closed
@manidlou manidlou merged commit 7c251d6 into master May 13, 2019
@manidlou manidlou deleted the fix-max-call-stack branch May 13, 2019 16:27
@manidlou
Copy link
Collaborator Author

@RyanZim the soonest that I can publish a patch is tonight, but if you can do it sooner, that'd be great if you handle that. Thank you!

@manidlou
Copy link
Collaborator Author

@RyanZim I went ahead and published a patch v8.0.1.

@RyanZim
Copy link
Collaborator

RyanZim commented May 13, 2019

@manidlou Thanks, perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim approved these changes

@JPeer264 JPeer264 JPeer264 approved these changes

@jprichardson jprichardson Awaiting requested review from jprichardson

Assignees

@manidlou manidlou

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[8.0.0] RangeError: Maximum call stack size exceeded at moveSync
4 participants
@manidlou @coveralls @RyanZim @JPeer264