Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/stat: fix max call stack size exceeded #679

Merged
merged 1 commit into from May 13, 2019

Conversation

@manidlou
Copy link
Collaborator

manidlou commented May 13, 2019

fixes #678.

  • resolve paths before parsing in util/stat.js
  • add util/stat tests
Copy link
Collaborator

JPeer264 left a comment

👍

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 13, 2019

Coverage Status

Coverage increased (+0.02%) to 83.903% when pulling 72278dc on fix-max-call-stack into a7f303b on master.

@manidlou manidlou requested review from JPeer264, jprichardson and RyanZim May 13, 2019
@manidlou manidlou self-assigned this May 13, 2019
@manidlou manidlou added the bug label May 13, 2019
Copy link
Collaborator

JPeer264 left a comment

Still good :)

@manidlou

This comment has been minimized.

Copy link
Collaborator Author

manidlou commented May 13, 2019

@jprichardson @RyanZim @JPeer264 please let me know if you have any concerns regarding this!

@manidlou manidlou force-pushed the fix-max-call-stack branch from 0600fde to 72278dc May 13, 2019
@manidlou

This comment has been minimized.

Copy link
Collaborator Author

manidlou commented May 13, 2019

rebased it. It should be ready now!

@manidlou manidlou merged commit 7c251d6 into master May 13, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 83.903%
Details
@manidlou manidlou deleted the fix-max-call-stack branch May 13, 2019
@manidlou

This comment has been minimized.

Copy link
Collaborator Author

manidlou commented May 13, 2019

@RyanZim the soonest that I can publish a patch is tonight, but if you can do it sooner, that'd be great if you handle that. Thank you!

@manidlou

This comment has been minimized.

Copy link
Collaborator Author

manidlou commented May 13, 2019

@RyanZim I went ahead and published a patch v8.0.1.

@RyanZim

This comment has been minimized.

Copy link
Collaborator

RyanZim commented May 13, 2019

@manidlou Thanks, perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.