move: do not create parent directory if it is root #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
reviewed
May 1, 2021
| // this test is a bit special since | ||
| // we're moving to root, so we need to | ||
| // manually remove dest after we're done. | ||
| fse.removeSync(dest) |
There was a problem hiding this comment.
Should be in an afterEach in this describeIfWindows block.
There was a problem hiding this comment.
Makes sense! I will update it then.
lib/move/__tests__/move.test.js
Outdated
| // this test is a bit special since | ||
| // we're moving to root, so we need to | ||
| // manually remove dest after we're done. | ||
| fse.remove(dest, done) |
RyanZim
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819.
Do not create parent directory if it is root. We run tests for this only on windows, moving to root on unix-like systems requires sudo privileges.