Allow passing undefined options to move() #948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
reviewed
Mar 16, 2022
RyanZim
reviewed
Mar 16, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
I have fixed the implementation to work with the existing tests and decided to add a unit test to cover this use case as well. |
RyanZim
reviewed
Mar 17, 2022
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
Tests are failing; haven't looked into it in detail. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
Created #955; which doesn't have the extra parameter validation, and has simpler tests. |
RyanZim
added a commit
that referenced
this pull request
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #947
I thought about adding a test but then couldn't find any tests of a similar nature within the repo so I didn't. I can if it is thought to be useful.