Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Strict Mode Warning: Can't call setState #1044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Strict Mode Warning: Can't call setState #1044

wants to merge 1 commit into from

Conversation

sloosch
Copy link

@sloosch sloosch commented Nov 9, 2020

Closes #951

modal handlers are now registered after the component did mount to avoid setState during the mounting phase.

@charlesomer charlesomer mentioned this pull request Dec 2, 2020
Open
@absingh927
Copy link

@jpuri any chance the PRs can be looked at, it would solve a few issues pretty quickly! 😄

@Fox4148 Fox4148 mentioned this pull request Mar 11, 2021
Open
Fox4148
Fox4148 approved these changes Mar 11, 2021
View reviewed changes
Copy link

@Fox4148 Fox4148 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe lifecycle methods.
@sloosch Can you add a Tag on your specific commit? So I can reference it in my project npm dependencies

@Sam-CellarDoor
Copy link

@jpuri Ended up forking to solve this issue. If you have the time this is a quick fix with big impact!

@lud-hu
Copy link

lud-hu commented Dec 25, 2021

Any news on this? Would be great if it would be merged. :)

@hovvahan94
Copy link

Can anybody make this branch work?)

@siddjain siddjain mentioned this pull request Feb 10, 2022
Open
@stormdotcom
Copy link

any resolves found yet? i have project to complete

@Neirea Neirea mentioned this pull request Mar 28, 2022
Closed
@owen-soak owen-soak mentioned this pull request Jul 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliethedev olliethedev olliethedev approved these changes

@Fox4148 Fox4148 Fox4148 approved these changes

@Guilherme-Farias Guilherme-Farias Guilherme-Farias approved these changes

@somebodyawesome-dev somebodyawesome-dev somebodyawesome-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning: Can't call setState
10 participants
@sloosch @absingh927 @Sam-CellarDoor @lud-hu @hovvahan94 @stormdotcom @olliethedev @Fox4148 @Guilherme-Farias @somebodyawesome-dev