Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable delete image option. Added image validation on upload by drag and drop. #629

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Huespal
Copy link

@Huespal Huespal commented Mar 15, 2018

Added the possibility to have an option, that appears on image hover, to delete the image from the editor.

@jpuri
Copy link
Owner

jpuri commented Mar 15, 2018

Thanks @Huespal , I will soon check this.

@Huespal
Copy link
Author

Huespal commented Mar 20, 2018

I have added another mini-feature/improvement. Dropped images in file upload panel now also validates with accepted image types. For example: now you can not upload a gif by drag and drop if gif image type is not in accepted images types.

@Huespal Huespal changed the title Added configurable delete image option. Added configurable delete image option. Added image validation on upload by drag and drop. Mar 20, 2018
@willbuckingham
Copy link

@jpuri Any chance on this being merged? as it may provide a work around for #489

@jpuri
Copy link
Owner

jpuri commented Feb 9, 2019

Yep I will check this soon.

@Pashaster12
Copy link

@jpuri process it, please.

@simonbowen
Copy link

Any update on this? Being able to delete an image is pretty useful.

@justinhandley
Copy link

It seems like this is still an issue - this has been open for almost two years - any plan to ever pull it in?

@megphillips91
Copy link

Wait, so is this still unresolved? I can't delete images from the editor... June 16, 2020

@alfredoTorreblanca
Copy link

Hi, @jpuri !! I think it would be good to have this!!

@astraey
Copy link

astraey commented Aug 31, 2020

Any updates guys?

@igorsabarense
Copy link

@Huespal

Added the possibility to have an option, that appears on image hover, to delete the image from the editor.

any chance you could fork draft-js and upload it with your change ?

@crippled-ankle
Copy link

Can we resolve the merge conflicts and get it merged please?

@Huespal @jpuri

@jaypeemayo
Copy link

any updates?

@jaypeemayo
Copy link

@jpuri resolve conflict and merge please. thanks

@Damiandeveloper26
Copy link

@jpuri please fix it

@juliachennn
Copy link

@jpuri The problem is still here. Please fix it ~~

@pavlokadysh
Copy link

@jpuri The issue is still present. Can you please take a look. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.