Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support slice operator in JString to match Python str #833

Merged
merged 2 commits into from
Aug 9, 2020
Merged

Support slice operator in JString to match Python str #833

merged 2 commits into from
Aug 9, 2020

Conversation

Thrameos
Copy link
Contributor

@Thrameos Thrameos commented Aug 4, 2020

This addresses a common incompatiblity between Java string and Python str types by adding a slice functionality to __getitem__.

Fixes #831

@Thrameos Thrameos added the enhancement Improvement in capability planned for future release label Aug 4, 2020
@Thrameos Thrameos added this to the JPype 1.1 milestone Aug 4, 2020
@Thrameos Thrameos requested a review from marscher August 4, 2020 04:11
@Thrameos Thrameos self-assigned this Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020 •
edited
Loading

Codecov Report

Merging #833 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
+ Coverage   92.42%   92.43%   +0.01%     
==========================================
  Files          24       24              
  Lines        1453     1455       +2     
==========================================
+ Hits         1343     1345       +2     
  Misses        110      110
Impacted Files Coverage Δ
jpype/_jstring.py 97.05% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e539a...91a56b9. Read the comment docs.

@Thrameos Thrameos mentioned this pull request Aug 4, 2020
Closed
marscher
marscher approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@marscher marscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well. That was missing for a long time. Thanks for adding it.

@marscher marscher merged commit 9f551cc into jpype-project:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marscher marscher marscher approved these changes

Assignees

@Thrameos Thrameos

Labels
enhancement Improvement in capability planned for future release
Projects
None yet
Milestone
JPype 1.1
Development

Successfully merging this pull request may close these issues.

JString slice operator
2 participants
@Thrameos @marscher