Extend fuzzing set up #2952
Merged
Extend fuzzing set up #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a parse function ins `jv_parse.c` that enables parsing using custom flags for the parser. This is then used by two fuzzers added as well. This is to make sure fuzzing hits various code parts currently not fuzzed, e.g. `stream_token`: https://storage.googleapis.com/oss-fuzz-coverage/jq/reports/20231125/linux/src/jq/src/jv_parse.c.html#L241 Signed-off-by: David Korczynski <david@adalogics.com>
|
Am not sure if adding |
|
I think it's ok to add a new function, but maybe make Thank you for adding more fuzzing! PS: Could you also add a fuzzer for |
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
Done!
Added! Once this is landed I'll add the new fuzzers to https://github.com/google/oss-fuzz/blob/master/projects/jq/build.sh |
|
Thank you! |
emanuele6
added a commit
to emanuele6/jq-1
that referenced
this pull request
Nov 28, 2023
jv_dump() frees its argument. I missed this problem before merging jqlang#2952, whoops! =) fixup from eb3b565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parse function in
jv_parse.cthat enables parsing using custom flags for the parser. This is then used by two fuzzers added as well.This is to make sure fuzzing hits various code parts currently not fuzzed, e.g.
stream_token:https://storage.googleapis.com/oss-fuzz-coverage/jq/reports/20231125/linux/src/jq/src/jv_parse.c.html#L241