builtin.c: fix build with -Woverlength-strings #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
reviewed
Jan 26, 2024
wader
reviewed
Jan 26, 2024
wader
approved these changes
Jan 26, 2024
emanuele6
commented
Jan 26, 2024
C99 only allows string literals long at most 4095 characters.
jq_builtins was a lot longer than that.
I rewrote all the optional libm error stubs in C so the value of
jq_builtins is not build dependent.
I replaced the command that generates builtin.inc with a POSIX compliant
od|sed command that encodes builtin.jq as a comma delimited list of
octal numbers (that can be embedded in C using a {} literal).
I also added -Woverlength-strings to AM_CFLAGS to verify that the
problem is fixed.
Fixes jqlang#1481
emanuele6
force-pushed
the
fixlongstringv2
branch
2 times, most recently
from
d34fcea
to
f0ca565
Compare
wader
reviewed
Jan 26, 2024
wader
approved these changes
Jan 26, 2024
emanuele6
commented
Jan 26, 2024
emanuele6
force-pushed
the
fixlongstringv2
branch
from
f0ca565
to
843c8f7
Compare
wader
approved these changes
Jan 26, 2024
emanuele6
commented
Jan 26, 2024
For functions that from one double return an array with two numbers.
emanuele6
force-pushed
the
fixlongstringv2
branch
from
843c8f7
to
ba88023
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C99 only allows string literals long at most 4095 characters.
jq_builtinswas a lot longer than that.I rewrote all the optional libm error stubs in C so the value of
jq_builtinsis not build dependent.I replaced the command that generates builtin.inc with a POSIX compliant od|sed command that encodes builtin.jq as a comma delimited list of octal numbers (that can be embedded in C using a
{}literal).I also added
-Woverlength-stringstoAM_CFLAGSto verify that the problem is fixed.Fixes #1481