Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preview] Allow props to override defaults #5

Merged
merged 3 commits into from
Jan 30, 2021

Conversation

mbrookes
Copy link
Contributor

Closes #4

@jquense
Copy link
Owner

jquense commented Jan 30, 2021

We should move just the aria label prop above the spread so the other props can't be overridden accidently

@mbrookes
Copy link
Contributor Author

I've updated it so that the two hardcoded props can be overridden. In terms of code style, any preference as to whether the other props should live in the object or directly in the div?

Copy link
Owner

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'd prefer the props to be online in the div but I don't care that much if it's a pain to change

@jquense jquense merged commit 3e3e3a7 into jquense:master Jan 30, 2021
@jquense
Copy link
Owner

jquense commented Jan 30, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to override arial-label on Preview component
2 participants