Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: time gutter position features #2472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bzbetty
Copy link

@bzbetty bzbetty commented Nov 23, 2023

Allows the time gutter to be on the Left (default), Right, or Both

image

image

@cutterbl
Copy link
Collaborator

This looks really good. Only thing I see missing is a story under /stories/props.

@bzbetty
Copy link
Author

bzbetty commented Nov 28, 2023

Added in a story under /stories/props for TimeGutterPosition

@cutterbl
Copy link
Collaborator

OK, finally had a little more time to look at this. First, Thank You for your PR, and adding the base level documentation, though you did miss adding the prop/link to the Full Prop List.

A more detailed review shows one item that, while it doesn't appear to be currently causing an issue, may create one. The TimeGutter gets a ref. Currently you're assigning the same ref even when you have two gutters (left and right). This is used for measurement layout in the measureGutter() method. Might be nothing to worry about, but does set off some bells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants