Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add japanese language support #2583

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ikrammt
Copy link
Contributor

@ikrammt ikrammt commented Apr 26, 2024

This pull request introduces support for the Japanese language (ja) #2581 in the react-big-calendar library. This enhancement expands the user base by enabling users who prefer Japanese to interact with the calendar interface and labels in their native language.

@cutterbl
Copy link
Collaborator

I appreciate your general thought process here. But, Big Calendar, on it's own, does not provide any speciific language localization support, but rather the tools and props necessary to allow a developer to localize as necessary. While you've improved this story a bit, showing how to do this in Japanese, perhaps a better option may be in providing a more in depth story in the 'Guides' section, detailing the ins and outs of properly providing localization support.

@ikrammt
Copy link
Contributor Author

ikrammt commented May 4, 2024

Thanks for the feedback! You're absolutely right, Big Calendar itself doesn't handle localization directly. However, showcasing a basic example like the Japanese one is a good start.I will definitely add it to the 'Guides' section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants