Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

What do you think about unifying data types of 'collapsedlcon' in collapsible widget? #6709

Closed
allsteady opened this issue Nov 8, 2013 · 1 comment

Comments

@allsteady
Copy link
Contributor

Hi all.

According to the following API document,
collapsedlcon type in Options of Collapsible widget is defined as two kind.


API : https://github.com/jquery/api.jquerymobile.com/blob/1-4/entries/collapsible.xml (line: 138~150)
collapsedIconType: String or Boolean
Default: "plus"

Multiple types supported:
• String: The name of the icon you wish to use.
• Boolean: In addition to an icon name, you can also set this option to false. In that case, the collapsible will not have an icon in either the expanded or collapsed state. Add data-collapsed-icon="false" to the collapsible widget to set the option to false via the data attribute.


I think that a user will be confused by this option.
And widget may have a possibility to act incorrectly.
Such as, If a user assign the value to "false" of String type, the icon would be not disappeared.

Therefore, I think that we unify into the String type.

This issue is concerned with #6708.

@gabrielschulhof
Copy link

After discussing the matter with @uGoMobi we've decided to keep the dual-type option for collapsedIcon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants