Skip to content
This repository has been archived by the owner on Dec 11, 2021. It is now read-only.

Build: make JSCS and JSHint lint the grunt config too #103

Closed
wants to merge 2 commits into from
Closed

Build: make JSCS and JSHint lint the grunt config too #103

wants to merge 2 commits into from

Conversation

arthurvr
Copy link
Contributor

This makes JSHint and JSCS lint the files in tasks/ too. I asked this but seems like @arschmitz forgot it: #89 (comment).

@arthurvr
Copy link
Contributor Author

The CI failure is on master too.

var jsass = require( "jsass-vars" );
var path = require( "path" );
var varPath = path.join( process.cwd(), "scss/variables/*" );
var jsass = require( "jsass-vars" ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One var is no longer a requirment but we need to update our version of JSCS for it to not complain.

@arschmitz
Copy link
Contributor

@arthurvr looks good other then id prefer to update and not use one var any more.

@arthurvr
Copy link
Contributor Author

not use one var any more.

I considered it unrelated to this PR, but yeah, updated now.

other then id prefer to update

Can you elaborate?

@arschmitz
Copy link
Contributor

@arthurvr I just meant i would prefer to update jscs then leave one var. Thats all i have.

@sfrisk
Copy link
Contributor

sfrisk commented Aug 4, 2015

Hey @arthurvr, when you have a sec, could you update this with master?

@arthurvr
Copy link
Contributor Author

arthurvr commented Aug 4, 2015

Yep, I totally can! It'll have to wait ~2 weeks though. It's only a
semicolon.
On di 4 aug. 2015 at 06:39 Sarah Frisk notifications@github.com wrote:

Hey @arthurvr https://github.com/arthurvr, when you have a sec, could
you update this with master?


Reply to this email directly or view it on GitHub
#103 (comment).

@sfrisk
Copy link
Contributor

sfrisk commented Aug 4, 2015

Oh if it is just that I will fix it. I didn't look to closely at what was causing it last night.

Sent from my iPhone

On Aug 4, 2015, at 2:05 AM, Arthur Verschaeve notifications@github.com wrote:

Yep, I totally can! It'll have to wait ~2 weeks though. It's only a
semicolon.
On di 4 aug. 2015 at 06:39 Sarah Frisk notifications@github.com wrote:

Hey @arthurvr https://github.com/arthurvr, when you have a sec, could
you update this with master?


Reply to this email directly or view it on GitHub
#103 (comment).


Reply to this email directly or view it on GitHub.

@sfrisk sfrisk closed this in 091e54b Aug 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants