-
Notifications
You must be signed in to change notification settings - Fork 67
Build: make JSCS and JSHint lint the grunt config too #103
Conversation
The CI failure is on master too. |
var jsass = require( "jsass-vars" ); | ||
var path = require( "path" ); | ||
var varPath = path.join( process.cwd(), "scss/variables/*" ); | ||
var jsass = require( "jsass-vars" ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One var is no longer a requirment but we need to update our version of JSCS for it to not complain.
@arthurvr looks good other then id prefer to update and not use one var any more. |
I considered it unrelated to this PR, but yeah, updated now.
Can you elaborate? |
@arthurvr I just meant i would prefer to update jscs then leave one var. Thats all i have. |
Hey @arthurvr, when you have a sec, could you update this with master? |
Yep, I totally can! It'll have to wait ~2 weeks though. It's only a
|
Oh if it is just that I will fix it. I didn't look to closely at what was causing it last night. Sent from my iPhone
|
This makes JSHint and JSCS lint the files in
tasks/
too. I asked this but seems like @arschmitz forgot it: #89 (comment).