Prohibit labelled class/generator/function declaration #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore the failing downstream test. It's is a false alarm, it's due to Assetgraph not working with the latest ESLint (see assetgraph/assetgraph#662 for more details). |
|
Super interesting set of tests. I learn more about JS reviewing these PRs then anywhere else. 👍 |
ariya
added a commit
to ariya/esprima
that referenced
this pull request
Dec 11, 2016
ariya
added a commit
that referenced
this pull request
Dec 11, 2016
The only allowed situation is labelled function declaration in non-strict mode (for web compatibility reason). Fix jquery#1484
Current coverage is 100% (diff: 100%)@@ master #1665 diff @@
=====================================
Files 1 1
Lines 3955 3967 +12
Methods 0 0
Messages 0 0
Branches 682 686 +4
=====================================
+ Hits 3955 3967 +12
Misses 0 0
Partials 0 0
|
ariya
added a commit
to ariya/esprima
that referenced
this pull request
Dec 16, 2016
The workaround is not necessary anymore (solved in AssetGraph itself). Refs jquery#1665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only allowed situation is labelled function declaration in non-strict mode
(for web compatibility reason).
Fix #1484