Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Expose an overlay theme option for dialogs and selects #2871
Currently, the background "overlay" that sits behind a dialog or small/large custom selects to give it s modal appearance is hard-coded to swatch A which is fine with the default theme, but isn't going to work for all themes out there.
We can leave swatch A as the default for these, but we should expose an
referenced this issue
Nov 1, 2011
pushed a commit
Nov 5, 2011
The issue it caused me, was that I do not have any of the themes installed, I created my own custom themes. So when I upgraded it was looking for theme "a" with the .ui-body-a.ui-overlay-a tag instead of just the .ui-overlay-X tag. Looking for just the .ui-overlay-X seems more logical in my mind, because I don't really care what the body is, I want the dialog theme to be set to what I define it as without relying on the body.
Just an observation. Thanks for the great work.
The issue is that the overlay wasn't themable and we don't have an overlay lever in TR so we're using whatever content swatch you want. I suppose we could introduce an overlay lever in TR in the next release which would work globally, but that is less flexible than the current system.