New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose an overlay theme option for dialogs and selects #2871

Closed
toddparker opened this Issue Oct 28, 2011 · 4 comments

Comments

Projects
None yet
3 participants
@toddparker
Contributor

toddparker commented Oct 28, 2011

Currently, the background "overlay" that sits behind a dialog or small/large custom selects to give it s modal appearance is hard-coded to swatch A which is fine with the default theme, but isn't going to work for all themes out there.

We can leave swatch A as the default for these, but we should expose an overlayTheme option in both these plugins to allow people to set this by passing in a swatch letter. This will also be exposed as a data-overlay-theme attribute that can be applied on:

@smwald

This comment has been minimized.

Show comment
Hide comment
@smwald

smwald Nov 14, 2011

Seems that this fix only works if the theme is labeled with both: .ui-body-a, as well as .ui-dialog.ui-overlay-a,
I am not sure if this was by design or a mistake - seems it should only require a .ui-dialog.ui-overlay-X tag...

Stephen

smwald commented Nov 14, 2011

Seems that this fix only works if the theme is labeled with both: .ui-body-a, as well as .ui-dialog.ui-overlay-a,
I am not sure if this was by design or a mistake - seems it should only require a .ui-dialog.ui-overlay-X tag...

Stephen

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Nov 15, 2011

Member

@smwald

It was intentional I added another more specific rule that will take precedence over the .ui-body-X for the overlay because you can open a page in a dialog and a page has .ui-body-X on it. Does that cause a problem?

Member

gseguin commented Nov 15, 2011

@smwald

It was intentional I added another more specific rule that will take precedence over the .ui-body-X for the overlay because you can open a page in a dialog and a page has .ui-body-X on it. Does that cause a problem?

@smwald

This comment has been minimized.

Show comment
Hide comment
@smwald

smwald Nov 15, 2011

The issue it caused me, was that I do not have any of the themes installed, I created my own custom themes. So when I upgraded it was looking for theme "a" with the .ui-body-a.ui-overlay-a tag instead of just the .ui-overlay-X tag. Looking for just the .ui-overlay-X seems more logical in my mind, because I don't really care what the body is, I want the dialog theme to be set to what I define it as without relying on the body.

Just an observation. Thanks for the great work.

smwald commented Nov 15, 2011

The issue it caused me, was that I do not have any of the themes installed, I created my own custom themes. So when I upgraded it was looking for theme "a" with the .ui-body-a.ui-overlay-a tag instead of just the .ui-overlay-X tag. Looking for just the .ui-overlay-X seems more logical in my mind, because I don't really care what the body is, I want the dialog theme to be set to what I define it as without relying on the body.

Just an observation. Thanks for the great work.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Nov 15, 2011

Contributor

The issue is that the overlay wasn't themable and we don't have an overlay lever in TR so we're using whatever content swatch you want. I suppose we could introduce an overlay lever in TR in the next release which would work globally, but that is less flexible than the current system.

Contributor

toddparker commented Nov 15, 2011

The issue is that the overlay wasn't themable and we don't have an overlay lever in TR so we're using whatever content swatch you want. I suppose we could introduce an overlay lever in TR in the next release which would work globally, but that is less flexible than the current system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment