Expose an overlay theme option for dialogs and selects #2871

Closed
toddparker opened this Issue Oct 28, 2011 · 4 comments

Projects

None yet

3 participants

@toddparker
Contributor

Currently, the background "overlay" that sits behind a dialog or small/large custom selects to give it s modal appearance is hard-coded to swatch A which is fine with the default theme, but isn't going to work for all themes out there.

We can leave swatch A as the default for these, but we should expose an overlayTheme option in both these plugins to allow people to set this by passing in a swatch letter. This will also be exposed as a data-overlay-theme attribute that can be applied on:

@gseguin gseguin was assigned Oct 28, 2011
@gseguin gseguin pushed a commit that referenced this issue Nov 5, 2011
Ghislain Seguin Fix for #2871: Added overlayTheme option to dialog widget 26c48c8
@gseguin gseguin closed this Nov 7, 2011
@smwald
smwald commented Nov 14, 2011

Seems that this fix only works if the theme is labeled with both: .ui-body-a, as well as .ui-dialog.ui-overlay-a,
I am not sure if this was by design or a mistake - seems it should only require a .ui-dialog.ui-overlay-X tag...

Stephen

@gseguin
Member
gseguin commented Nov 15, 2011

@smwald

It was intentional I added another more specific rule that will take precedence over the .ui-body-X for the overlay because you can open a page in a dialog and a page has .ui-body-X on it. Does that cause a problem?

@smwald
smwald commented Nov 15, 2011

The issue it caused me, was that I do not have any of the themes installed, I created my own custom themes. So when I upgraded it was looking for theme "a" with the .ui-body-a.ui-overlay-a tag instead of just the .ui-overlay-X tag. Looking for just the .ui-overlay-X seems more logical in my mind, because I don't really care what the body is, I want the dialog theme to be set to what I define it as without relying on the body.

Just an observation. Thanks for the great work.

@toddparker
Contributor

The issue is that the overlay wasn't themable and we don't have an overlay lever in TR so we're using whatever content swatch you want. I suppose we could introduce an overlay lever in TR in the next release which would work globally, but that is less flexible than the current system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment