Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Selectmenu non-native theming problem #7957

Closed
slavap opened this issue Feb 4, 2015 · 12 comments
Closed

Selectmenu non-native theming problem #7957

slavap opened this issue Feb 4, 2015 · 12 comments
Assignees
Labels

Comments

@slavap
Copy link

slavap commented Feb 4, 2015

Test case: http://jsbin.com/husohaluqo/1/edit?html,css,js,output

Page theme "a", header theme "b", selectmenu on header.
If no theme explicitly defined for selectmenu it will be styled as parent (header). But popup is styled incorrectly as "a" (page).

Also it would be nice to have separate option for popup styling, because often it should be styled quite differently.

@jaspermdegroot
Copy link
Contributor

This is not a bug in the framework, but something we should probably document better.
Custom selects use the popup widget for the menu. Because the popup container is elsewhere on the page it can't inherit the theme swatch from the parent of the select, and inherits from the page instead.
This is documented for popup but not in the selectmenu API docs.

@slavap
Copy link
Author

slavap commented Feb 19, 2015

Thanks for clarification, though it looks very strange, and enforces always to specify theme explicitly for selectmenus on header.
What about implementing separate option in selectmenu for popup styling?

@jaspermdegroot
Copy link
Contributor

@slavap

What about implementing separate option in selectmenu for popup styling?

You can style the selectmenu popup. See http://jsbin.com/qavisoxaro/1/edit?html,output

@slavap
Copy link
Author

slavap commented Feb 20, 2015

data-overlay-theme="none" removes/changes style for "fading" cover. But popup with list items itself is not changing. It's not possible to define theme "b" for selectmenu and for example theme "c" for its selection popup.

@marti1125
Copy link
Contributor

Hi @jaspermdegroot any update ? Can I help you?

@jaspermdegroot
Copy link
Contributor

hi @marti1125

Help is always welcome! If you can open a PR in the https://github.com/jquery/api.jquerymobile.com repo to make the changes as I described in my comment #7957 (comment) above that would be great! Thanks!

@marti1125
Copy link
Contributor

Hi @jaspermdegroot
I'm trying to deploy api.jquerymobile.com but I have error with grunt taks. When I run grunt deploy I get an error about Running "build-xml-entries:all" (build-xml-entries) task
captura de pantalla 2016-03-25 a las 23 33 17

I added in Mac OS: libxml2 and libxslt
I used this instructions http://ripary.com/libxml2_leopoard.html

@jaspermdegroot
Copy link
Contributor

@marti1125

Yeah, I did hear about problems with deploying the API docs. I think they were fixed by now, but I am not sure to be honest. If you still encounter problems please open a ticket at the API docs repo so the people that are looking into this will be aware of it.

@agcolom
Copy link
Contributor

agcolom commented Apr 2, 2016

@marti1125 @jaspermdegroot Yes, this issue around the deployment of the api docs was fixed by jquery/api.jquerymobile.com@c995002#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 and jquery/jquery-wp-content@836858d

@jaspermdegroot
Copy link
Contributor

@agcolom

That's great. Thanks for the update!

@marti1125
Copy link
Contributor

@agcolom thanks!!

@marti1125
Copy link
Contributor

Hi @jonathansampson could you check my PR please =D

@apsdehal apsdehal self-assigned this Aug 3, 2016
apsdehal pushed a commit to jquery/api.jquerymobile.com that referenced this issue Feb 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants