This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fix issue #1692 #1750
Closed
Fix issue #1692 #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with menuType="page" rather than falling back to default click handler's window.history.back() call. This fixes issue jquery-archive#1692
|
Thanks! Does this work for clicking either the back button or the custom close button? It'll need to support both in the end. |
|
It only works when using the custom close button at present - I haven't yet familiarised myself with enough of the jQuery Mobile code to have worked out the best way to hook into the chain of events triggered from the browser back button to implement this there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call close() function when clicking close button on dialog for selects with menuType="page" rather than falling back to default click handler's window.history.back() call.