New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1692 #1750

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@pauln
Contributor

pauln commented Jun 1, 2011

Call close() function when clicking close button on dialog for selects with menuType="page" rather than falling back to default click handler's window.history.back() call.

Call close() function when clicking close button on dialog for select…
…s with menuType="page" rather than falling back to default click handler's window.history.back() call. This fixes issue #1692
@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jun 9, 2011

Contributor

Thanks! Does this work for clicking either the back button or the custom close button? It'll need to support both in the end.

Contributor

scottjehl commented Jun 9, 2011

Thanks! Does this work for clicking either the back button or the custom close button? It'll need to support both in the end.

@pauln

This comment has been minimized.

Show comment
Hide comment
@pauln

pauln Jun 12, 2011

Contributor

It only works when using the custom close button at present - I haven't yet familiarised myself with enough of the jQuery Mobile code to have worked out the best way to hook into the chain of events triggered from the browser back button to implement this there.

Contributor

pauln commented Jun 12, 2011

It only works when using the custom close button at present - I haven't yet familiarised myself with enough of the jQuery Mobile code to have worked out the best way to hook into the chain of events triggered from the browser back button to implement this there.

@scottjehl scottjehl closed this in ada4673 Jul 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment