Fix issue #1692 #1750

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@pauln

Call close() function when clicking close button on dialog for selects with menuType="page" rather than falling back to default click handler's window.history.back() call.

@pauln pauln Call close() function when clicking close button on dialog for select…
…s with menuType="page" rather than falling back to default click handler's window.history.back() call. This fixes issue #1692
9c84088
@scottjehl

Thanks! Does this work for clicking either the back button or the custom close button? It'll need to support both in the end.

@pauln

It only works when using the custom close button at present - I haven't yet familiarised myself with enough of the jQuery Mobile code to have worked out the best way to hook into the chain of events triggered from the browser back button to implement this there.

@scottjehl scottjehl pushed a commit that closed this pull request Jul 11, 2011
scottjehl abstracted out some of the page hide behavior to fix issues with the …
…close button not returning focus to the button after closing. Also fixes an issue where a full page custom menu would open as a misplaced small custom menu the second time it opens (if the menu was closed via the custom close button). Fixes #1618. Fixes #1692. Fixes #1750.
ada4673
@scottjehl scottjehl closed this in ada4673 Jul 11, 2011
@timmywil timmywil pushed a commit that referenced this pull request Oct 24, 2011
scottjehl abstracted out some of the page hide behavior to fix issues with the …
…close button not returning focus to the button after closing. Also fixes an issue where a full page custom menu would open as a misplaced small custom menu the second time it opens (if the menu was closed via the custom close button). Fixes #1618. Fixes #1692. Fixes #1750.
adea325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment