New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top corner in inset list with two items fails #1996

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@wietsevenema
Contributor

wietsevenema commented Jun 30, 2011

Hi there,

The top corner style doesn't get applied in an inset list with two items (other number of items work fine). I added a red test for your convenience.

Regards,
Wietse

@negue

This comment has been minimized.

Show comment
Hide comment
@negue

negue Jun 30, 2011

Contributor

Yeah, if I use the version of http://code.jquery.com/mobile/latest/jquery.mobile.zip it still works, so something broke between the last version and the currently git version

Contributor

negue commented Jun 30, 2011

Yeah, if I use the version of http://code.jquery.com/mobile/latest/jquery.mobile.zip it still works, so something broke between the last version and the currently git version

@robcaldecott

This comment has been minimized.

Show comment
Hide comment
@robcaldecott

robcaldecott Jul 5, 2011

Does anyone have a fix for this I can use?

robcaldecott commented Jul 5, 2011

Does anyone have a fix for this I can use?

@negue

This comment has been minimized.

Show comment
Hide comment
@negue

negue Jul 5, 2011

Contributor

Did you tried the latest git version? I think it is kinda fixed.

Contributor

negue commented Jul 5, 2011

Did you tried the latest git version? I think it is kinda fixed.

@robcaldecott

This comment has been minimized.

Show comment
Hide comment
@negue

This comment has been minimized.

Show comment
Hide comment
@negue

negue Jul 5, 2011

Contributor

I have cloned the repo, all JS-Files to one File, and with this the topcorner bug is gone.

Anyway try the git sources.

Contributor

negue commented Jul 5, 2011

I have cloned the repo, all JS-Files to one File, and with this the topcorner bug is gone.

Anyway try the git sources.

@robcaldecott

This comment has been minimized.

Show comment
Hide comment
@robcaldecott

robcaldecott Jul 5, 2011

OK, thanks. When does the latest get updated from git? Automatically every few days or is it a manual process?

robcaldecott commented Jul 5, 2011

OK, thanks. When does the latest get updated from git? Automatically every few days or is it a manual process?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 5, 2011

It still exists in the nightly dated Sat Jul 2 09:03:02 2011 -0700

You can see it using the test pages under
"List views -> Read-only inset lists" and look for the "Divided, formatted content" section.

ghost commented Jul 5, 2011

It still exists in the nightly dated Sat Jul 2 09:03:02 2011 -0700

You can see it using the test pages under
"List views -> Read-only inset lists" and look for the "Divided, formatted content" section.

@negue

This comment has been minimized.

Show comment
Hide comment
@negue

negue Jul 5, 2011

Contributor

Okey, after re-pulling the sources and switching the branch (git is strange, sry), i get the "real current" sources the bug is still there.

Untill it is fixed, I use this older version:
http://dl.dropbox.com/u/1760223/jquery-mobile/jquery.mobile.js

Contributor

negue commented Jul 5, 2011

Okey, after re-pulling the sources and switching the branch (git is strange, sry), i get the "real current" sources the bug is still there.

Untill it is fixed, I use this older version:
http://dl.dropbox.com/u/1760223/jquery-mobile/jquery.mobile.js

@robcaldecott

This comment has been minimized.

Show comment
Hide comment
@robcaldecott

robcaldecott Jul 7, 2011

Anyone know if this is scheduled to be fixed soon? This bug still exists in the latest CDN version. Is there a CSS override I can use to fix this?

robcaldecott commented Jul 7, 2011

Anyone know if this is scheduled to be fixed soon? This bug still exists in the latest CDN version. Is there a CSS override I can use to fix this?

@negue

This comment has been minimized.

Show comment
Hide comment
@negue

negue Jul 8, 2011

Contributor

Well it is fixed. :P

Should I create a new Pull Request?

Contributor

negue commented Jul 8, 2011

Well it is fixed. :P

Should I create a new Pull Request?

@scottjehl scottjehl closed this in e567742 Jul 10, 2011

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jul 10, 2011

Contributor

Landed. thanks!

Contributor

scottjehl commented Jul 10, 2011

Landed. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment