Skip to content
This repository

Top corner in inset list with two items fails #1996

Closed
wants to merge 1 commit into from

5 participants

Wietse Venema negue robcaldecott mtemanson Scott Jehl
Wietse Venema

Hi there,

The top corner style doesn't get applied in an inset list with two items (other number of items work fine). I added a red test for your convenience.

Regards,
Wietse

negue
negue commented June 30, 2011

Yeah, if I use the version of http://code.jquery.com/mobile/latest/jquery.mobile.zip it still works, so something broke between the last version and the currently git version

robcaldecott

Does anyone have a fix for this I can use?

negue
negue commented July 05, 2011

Did you tried the latest git version? I think it is kinda fixed.

negue
negue commented July 05, 2011

I have cloned the repo, all JS-Files to one File, and with this the topcorner bug is gone.

Anyway try the git sources.

robcaldecott

OK, thanks. When does the latest get updated from git? Automatically every few days or is it a manual process?

mtemanson

It still exists in the nightly dated Sat Jul 2 09:03:02 2011 -0700

You can see it using the test pages under
"List views -> Read-only inset lists" and look for the "Divided, formatted content" section.

negue
negue commented July 05, 2011

Okey, after re-pulling the sources and switching the branch (git is strange, sry), i get the "real current" sources the bug is still there.

Untill it is fixed, I use this older version:
http://dl.dropbox.com/u/1760223/jquery-mobile/jquery.mobile.js

robcaldecott

Anyone know if this is scheduled to be fixed soon? This bug still exists in the latest CDN version. Is there a CSS override I can use to fix this?

negue negue referenced this pull request from a commit July 08, 2011
Commit has since been removed from the repository and is no longer available.
negue negue referenced this pull request from a commit July 08, 2011
negue Fix: #1996 Top Corners in nested listview add66ed
negue
negue commented July 08, 2011

Well it is fixed. :P

Should I create a new Pull Request?

Scott Jehl scottjehl closed this pull request from a commit July 10, 2011
fixed up logic and code style for the _removeCorners "which" argument…
…. Thx for the logic suggestion, @eugenb1. Fixes #1996.
e567742
Scott Jehl scottjehl closed this in e567742 July 10, 2011
Scott Jehl

Landed. thanks!

Timmy Willison timmywil referenced this pull request from a commit July 10, 2011
fixed up logic and code style for the _removeCorners "which" argument…
…. Thx for the logic suggestion, @eugenb1. Fixes #1996.
265b2d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jun 30, 2011
Wietse Venema added failing test for inset listview issue with top-corner dd2bdcd
This page is out of date. Refresh to see the latest.
12  tests/unit/listview/index.html
@@ -261,5 +261,17 @@ <h2 id="qunit-userAgent"></h2>
261 261
 	</div>
262 262
 </div>
263 263
 
  264
+<!-- Rounded corners inset list with variable items -->
  265
+<div  data-nstest-role="page" id='corner-rounded-test'>
  266
+	<div  data-nstest-role="header" data-nstest-position="inline">
  267
+		<h1>Basic List View</h1>
  268
+	</div>
  269
+	<div  data-nstest-role="content">
  270
+		<ul  data-nstest-role="listview" data-nstest-inset="true">
  271
+		</ul>
  272
+	</div>
  273
+</div>
  274
+
  275
+
264 276
 </body>
265 277
 </html>
27  tests/unit/listview/listview_core.js
@@ -453,7 +453,7 @@
453 453
 
454 454
 				ul.find("li").last().remove();
455 455
 				equal(ul.find("li").length, 2, "There should be only 2 list items left");
456  
-
  456
+				
457 457
 				ul.listview('refresh');
458 458
 				ok(ul.find("li").last().hasClass("ui-corner-bottom"), "Last list item should have class ui-corner-bottom");
459 459
 				start();
@@ -461,4 +461,29 @@
461 461
 		]);
462 462
 	});
463 463
 
  464
+	module("Rounded corners");
  465
+
  466
+	asyncTest("Top and bottom corners rounded in inset list", 10, function() {
  467
+		$.testHelper.pageSequence([
  468
+			function() {
  469
+				$.testHelper.openPage("#corner-rounded-test");
  470
+			},
  471
+
  472
+			function() {
  473
+				var ul = $('#corner-rounded-test ul');
  474
+				
  475
+				for( var t = 0; t<5; t++){
  476
+					ul.append("<li>Item " + t + "</li>");
  477
+					ul.listview('refresh');					
  478
+					ok(ul.find("li").first().hasClass("ui-corner-top"), "First list item should have class ui-corner-top in list with " + ul.find("li").length + " item(s)");
  479
+					ok(ul.find("li").last().hasClass("ui-corner-bottom"), "Last list item should have class ui-corner-bottom in list with " + ul.find("li").length + " item(s)");
  480
+				}
  481
+				
  482
+				start();
  483
+			}
  484
+		]);
  485
+	});
  486
+
  487
+
  488
+
464 489
 })(jQuery);
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.