This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Updated nested list pages to show back button #2030
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I drastically simplified my previous code by just looking for the data-add-back-btn attribute on the list and adding the attribute to the header template for the created page before the page.page() call. This way, the page() method can use it's existing logic to add the back button instead of repeating it here.
I'm still defaulting to showing the back button if not specified and I haven't included any ability to theme.