New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupled collapsible and collapsible set #3010

Merged
merged 5 commits into from Nov 17, 2011

Conversation

Projects
None yet
2 participants
@gseguin
Member

gseguin commented Nov 10, 2011

No description provided.

@gseguin gseguin closed this Nov 10, 2011

@gseguin gseguin reopened this Nov 10, 2011

gseguin added a commit that referenced this pull request Nov 17, 2011

Merge pull request #3010 from gseguin/issue-2905
Decoupled collapsible and collapsible set

@gseguin gseguin merged commit 3d17a69 into jquery:master Nov 17, 2011

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Feb 20, 2012

Contributor

@Wilto @gseguin

I could be wrong here but I think this commit covers more than a variable rename. This appears to be the cause of #3529. Can you guys sort out what should and shouldn't be there and add some tests to prevent this regression in the future? Happy presidents day!

Contributor

johnbender commented on 94389bd Feb 20, 2012

@Wilto @gseguin

I could be wrong here but I think this commit covers more than a variable rename. This appears to be the cause of #3529. Can you guys sort out what should and shouldn't be there and add some tests to prevent this regression in the future? Happy presidents day!

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Feb 23, 2012

Member

@johnbender

I remember now! This code was moved to jquery.mobile.collapsibleSet.js. Though you're right, the comment is very misleading.

Member

gseguin replied Feb 23, 2012

@johnbender

I remember now! This code was moved to jquery.mobile.collapsibleSet.js. Though you're right, the comment is very misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment