Standardize buttons and form #4498
Standardize buttons and form #4498
Conversation
…ncy between buttons in and outside forms.
…e consistency between browsers, since the default vertical alignment differs.
… buttons that are direct children of the header/footer.
…ps. Added flip toggle (ui-slider) label to the selectors.
…rapped in ui-field-contain since there is already padding.
…since we recommend to wrap in a div with class ui-bar to get padding.
…tal controlgroup.
… to prevent unwanted margin on FF.
…ader/footer possible.
…cal position of the split button icon.
Holy moly We need you guys to review this stuff. |
Zach and I tested http://ugomobi.github.com/buttons-form/ on the following platforms without any major issues, everything looked good. As long as that failing test is passing, this looks ready to land. Excellent work @uGoMobi Safari 4.1.3 Some minor issues I noticed: SAFARI 4.1.3: IPHONE 4, HTC INCREDIBLE, DROID TOUCH (all cells with smaller screen than the GALAXY NEXUS): OPERA MINI: -Under Control Group, Horizontal, Some of the "X" buttons are misaligned or completely out of the box underneath them. Menu Button overlaps Search Button. OPERA MOBILE: -Under Form, Cannot select any "Choices" (Full size or mini). The popup menu comes up for a second, than disappears. In the old one it works fine. |
…solute positioned to button and not to inner (small selectmenu buttons with padding for count and icon can cause inner sticking out the button). Removed display inline-block from span inside ui-select ui-btn-text to get overflow ellipses.
…doesn't understand min-width here. Changed line-height into height since this is a more consistent solution for all browsers.
Thanks a lot for the test result Todd and Zach!
[UPDATE:] I just found out we have a class ui-grid-solo for this. Will update the note in the docs.
The branch passed all unit tests. @toddparker - Do you want all commits to be cherry-picked into 1.1.1.? |
@uGoMobi - Great news. Why don't you land this (I'll give you the pleasure of hitting the big green button). Yes, let's cherry pick this to stable since they are bug fixes. We'll re-test the opera mobile issue once this lands. |
Standardize buttons and form
Standardize buttons and form
All changes are described in the changelog at the test page and in the commit messages.
Test page: http://ugomobi.github.com/buttons-form/
Fixes:
#3284
#3983
#3301
#3922
#1998
#2804
#3684
#4252
#4098
#3979
#4263
#4489