Deprecate style options #7348
Deprecate style options #7348
Conversation
|
@allsteady That's really good so far. Please also modify the elements which use |
|
@allsteady please do the same for |
| /* Negate Class | ||
| -----------------------------------------------------------------------------------------------------------*/ | ||
|
|
||
| .ui-corenr-none, .ui-corner-none.ui-corner-all { |
There was a problem hiding this comment.
There's a typo here. It should be .ui-corner-none
|
Please note that there should not be a period (.) at the end of the first line of the commit message (see http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines). |
|
@allsteady Could you please also use your full name as the commit author? |
jaspermdegroot
changed the title
jaspermdegroot
changed the title
| @@ -28,4 +28,4 @@ | |||
| width: 1px; | |||
| overflow: hidden; | |||
| clip: rect(1px,1px,1px,1px); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Missing blank line at EOF
|
@allsteady do you think you could add a comment inthe button widget above the options that are deprecated saying that they are deprecated in 1.5 and will be removed in 1.6 |
|
@arschmitz @allsteady I would hold off on saying they will be removed in 1.6, because we may not finish all style option removal, and IINM we've agreed that, if it takes longer, we keep those for which we've created CSS-based replacements deprecated until we remove them all at the same time in a future version (1.7.0 if we don't finish creating replacements in time for 1.5.0). |
|
@allsteady you should nevertheless add a comment saying that they are deprecated in 1.5.0. That part is for sure. |
Add css rule for negating a style option. - data-corner - data-shadow Fixes jquery-archivegh-7303
|
@allsteady will submit a second PR against the newly created branch "style-option-deprecation". |
Hi all
I add css rules for negating a style option.
If there are any problems or mistakes on that PR, please let me know. Thanks in advance.
Fixes gh-7303
Ref #7304