Skip to content
Permalink
Browse files

Progressbar: Conform to coding standards.

  • Loading branch information
scottgonzalez committed Feb 7, 2010
1 parent 573a402 commit f349f9080baf812a33faf742c54e7973c6411b89
Showing with 36 additions and 48 deletions.
  1. +36 −48 ui/jquery.ui.progressbar.js
@@ -11,109 +11,97 @@
* jquery.ui.core.js
* jquery.ui.widget.js
*/
(function($) {
(function( $ ) {

$.widget("ui.progressbar", {
$.widget( "ui.progressbar", {
options: {
value: 0
},
_create: function() {

this.element
.addClass("ui-progressbar"
+ " ui-widget"
+ " ui-widget-content"
+ " ui-corner-all")
.addClass( "ui-progressbar ui-widget ui-widget-content ui-corner-all" )
.attr({
role: "progressbar",
"aria-valuemin": this._valueMin(),
"aria-valuemax": this._valueMax(),
"aria-valuenow": this._value()
});

this.valueDiv = $('<div class="ui-progressbar-value ui-widget-header ui-corner-left"></div>').appendTo(this.element);
this.valueDiv = $( "<div class='ui-progressbar-value ui-widget-header ui-corner-left'></div>" )
.appendTo( this.element );

this._refreshValue();

},

destroy: function() {

this.element
.removeClass("ui-progressbar"
+ " ui-widget"
+ " ui-widget-content"
+ " ui-corner-all")
.removeAttr("role")
.removeAttr("aria-valuemin")
.removeAttr("aria-valuemax")
.removeAttr("aria-valuenow")
.removeData("progressbar")
.unbind(".progressbar");
.removeClass( "ui-progressbar ui-widget ui-widget-content ui-corner-all" )
.removeAttr( "role" )
.removeAttr( "aria-valuemin" )
.removeAttr( "aria-valuemax" )
.removeAttr( "aria-valuenow" );

this.valueDiv.remove();

$.Widget.prototype.destroy.apply(this, arguments);

return this;
$.Widget.prototype.destroy.apply( this, arguments );
},

value: function(newValue) {
if (newValue === undefined) {
value: function( newValue ) {
if ( newValue === undefined ) {
return this._value();
}
this._setOption('value', newValue);

this._setOption( "value", newValue );
return this;
},

_setOption: function(key, value) {

switch (key) {
case 'value':
_setOption: function( key, value ) {
switch ( key ) {
case "value":
this.options.value = value;
this._refreshValue();
this._trigger('change', null, {});
this._trigger( "change" );
break;
}

$.Widget.prototype._setOption.apply(this, arguments);

$.Widget.prototype._setOption.apply( this, arguments );
},

_value: function() {
var val = this.options.value;
// normalize invalid value
if (typeof val != "number")
if ( typeof val !== "number" ) {
val = 0;
if (val < this._valueMin()) val = this._valueMin();
if (val > this._valueMax()) val = this._valueMax();
}
if ( val < this._valueMin() ) {
val = this._valueMin();
}
if ( val > this._valueMax() ) {
val = this._valueMax();
}

return val;

},

_valueMin: function() {
var valueMin = 0;
return valueMin;
return 0;
},

_valueMax: function() {
var valueMax = 100;
return valueMax;
return 100;
},

_refreshValue: function() {
var value = this.value();
this.valueDiv[value == this._valueMax() ? 'addClass' : 'removeClass']("ui-corner-right");
this.valueDiv.width(value + '%');
this.element.attr("aria-valuenow", value);
this.valueDiv
[ value === this._valueMax() ? "addClass" : "removeClass"]( "ui-corner-right" )
.width( value + "%" );
this.element.attr( "aria-valuenow", value );
}

});

$.extend($.ui.progressbar, {
$.extend( $.ui.progressbar, {
version: "@VERSION"
});

})(jQuery);
})( jQuery );

0 comments on commit f349f90

Please sign in to comment.
You can’t perform that action at this time.