-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image optimize #121
Image optimize #121
Conversation
Hi @PeterDaveHello. Thank you for your PR, saving bandwidth for our users is certainly important. However, this process should be automated by using a Grunt task since we've already Grunt in place (unless we're already doing something on the server which I'm missing @gnarf). Can you send a PR based on my suggestion? |
@AurelioDeRosa I know automated progress is important, but I wonder how often the images will be changed? Especially members image, I have this question because the png optimization using zopflipng will take a long time, if you tried it, you will know, that will totally slow down the whole build process, if the images are not changed so often, isn't pre-compression acceptable? |
I'd agree that automation isn't that important here, but adding some notes
|
@gnarf What do you mean by the tactic used? Something like the tool adopted, the compression type, or the lossless compression vs non-lossless compression? |
I can add a note in readme to talk about the tools and parameters I used to do the compression 😄 |
Yup, basically we should have a guide about this, and spread info to the
|
@gnarf where should I put the guide? The readme in this repo? |
I think this would be more of a contribute thing...
|
I agree with @AurelioDeRosa i would prefer an automated approach. If this was truely just about jquery.org it would be fine but this effects all the websites. Most of the websites are also not maintained by @jquery/content but by individual team's members, and community contributions. If we just put this in readme it would have to go in every sites readme and would still likely be forgotten and ignored quickly. As for concerns about build time. Its fairly simple to setup a task to only run on files which have changed. Also given how often these sites are updated i don't think build time is a huge concern. |
So sometimes the best optimization is a different format image entirely, I agree with @AurelioDeRosa https://github.com/AurelioDeRosa i would As for concerns about build time. Its fairly simple to setup a task to only — |
Do we have any final decision here? This PR is stale now. |
Let's just close it. |
Optimize images losslessly to save to bandwidth to transfer :)