Skip to content
Permalink
Browse files

CSS: Don't auto-append "px" to CSS variables (#4064)

Fixes gh-4063
Closes gh-4064
  • Loading branch information...
mgol committed Jun 4, 2018
1 parent 45f0858 commit 75b77b4873abf9025b6ba60dec80aedd29df2bdd
Showing with 18 additions and 1 deletion.
  1. +3 −1 src/css.js
  2. +15 −0 test/unit/css.js
@@ -246,7 +246,9 @@ jQuery.extend( {
}

// If a number was passed in, add the unit (except for certain CSS properties)
if ( type === "number" ) {
// The isCustomProp check can be removed in jQuery 4.0 when we only auto-append
// "px" to a few hardcoded values.
if ( type === "number" && !isCustomProp ) {
value += ret && ret[ 3 ] || ( jQuery.cssNumber[ origName ] ? "" : "px" );
}

@@ -1659,6 +1659,21 @@ QUnit.test( "Do not throw on frame elements from css method (#15098)", function(
assert.equal( $elem.css( "--prop5" ), "'val5'", "Works with single quotes" );
}
} );

QUnit[ supportsCssVars ? "test" : "skip" ]( "Don't append px to CSS vars", function( assert ) {
assert.expect( 3 );

var $div = jQuery( "<div>" ).appendTo( "#qunit-fixture" );

$div
.css( "--a", 3 )
.css( "--line-height", 4 )
.css( "--lineHeight", 5 );

assert.equal( $div.css( "--a" ), "3", "--a: 3" );
assert.equal( $div.css( "--line-height" ), "4", "--line-height: 4" );
assert.equal( $div.css( "--lineHeight" ), "5", "--lineHeight: 5" );
} );
} )();

}

0 comments on commit 75b77b4

Please sign in to comment.
You can’t perform that action at this time.