New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Don't auto-append "px" to CSS variables #4064

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
4 participants
@mgol
Member

mgol commented Apr 30, 2018

Fixes gh-4063

Summary

Fixes gh-4063

Checklist

@mgol mgol added the CSS label Apr 30, 2018

@mgol mgol added this to the 3.4.0 milestone Apr 30, 2018

@mgol mgol added the Needs review label Apr 30, 2018

@@ -246,7 +246,9 @@ jQuery.extend( {
}
// If a number was passed in, add the unit (except for certain CSS properties)
if ( type === "number" ) {
// The isCustomProp check can be removed in jQuery 4.0 when we only auto-append

This comment has been minimized.

@Krinkle

Krinkle May 1, 2018

Member

Is there a url we can reference for this statement/plan?

This comment has been minimized.

@mgol

mgol May 2, 2018

Member

Once this PR lands I'll rebase #4055 and add a removal of this part there so I just need to remember about it until that moment. :)

This comment has been minimized.

@mgol

mgol Jun 4, 2018

Member

I landed this PR & rebased PR #4055, reverting this fix there.

@timmywil

LGTM

@timmywil timmywil removed the Needs review label May 14, 2018

@mgol mgol merged commit 75b77b4 into jquery:master Jun 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mgol mgol deleted the mgol:no-px-css-vars branch Jun 4, 2018

@GulajavaMinistudio GulajavaMinistudio referenced this pull request Jun 6, 2018

Merged

Update upstream #51

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment