Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery shouldn't auto-append "px" to CSS variables. #4063

Closed
mgol opened this issue Apr 30, 2018 · 1 comment
Closed

jQuery shouldn't auto-append "px" to CSS variables. #4063

mgol opened this issue Apr 30, 2018 · 1 comment

Comments

@mgol
Copy link
Member

@mgol mgol commented Apr 30, 2018

Description

jQuery shouldn't auto-append "px" to CSS variables.:

div.css( "--a", 3 ).css( "--a" ); // is: "3px", should be: "3"

Link to test case

https://jsfiddle.net/uxj3znv0/

@mgol mgol added this to the 3.4.0 milestone Apr 30, 2018
@mgol mgol self-assigned this Apr 30, 2018
mgol added a commit to mgol/jquery that referenced this issue Apr 30, 2018
@mgol
Copy link
Member Author

@mgol mgol commented Apr 30, 2018

PR: #4064

mgol added a commit to mgol/jquery that referenced this issue May 2, 2018
@mgol mgol closed this in #4064 Jun 4, 2018
mgol added a commit that referenced this issue Jun 4, 2018
Fixes gh-4063
Closes gh-4064
@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant