Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery shouldn't auto-append "px" to CSS variables. #4063

Closed
mgol opened this Issue Apr 30, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@mgol
Copy link
Member

commented Apr 30, 2018

Description

jQuery shouldn't auto-append "px" to CSS variables.:

div.css( "--a", 3 ).css( "--a" ); // is: "3px", should be: "3"

Link to test case

https://jsfiddle.net/uxj3znv0/

@mgol mgol added Bug CSS labels Apr 30, 2018

@mgol mgol added this to the 3.4.0 milestone Apr 30, 2018

@mgol mgol self-assigned this Apr 30, 2018

mgol added a commit to mgol/jquery that referenced this issue Apr 30, 2018

@mgol mgol referenced this issue Apr 30, 2018

Merged

CSS: Don't auto-append "px" to CSS variables #4064

3 of 3 tasks complete
@mgol

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2018

PR: #4064

mgol added a commit to mgol/jquery that referenced this issue May 2, 2018

@mgol mgol closed this in #4064 Jun 4, 2018

mgol added a commit that referenced this issue Jun 4, 2018

@GulajavaMinistudio GulajavaMinistudio referenced this issue Jun 6, 2018

Merged

Update upstream #51

0 of 4 tasks complete

@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.