Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery shouldn't auto-append "px" to CSS variables. #4063

Closed
mgol opened this issue Apr 30, 2018 · 1 comment · Fixed by #4064 or GulajavaMinistudio/jquery#51
Closed

jQuery shouldn't auto-append "px" to CSS variables. #4063

mgol opened this issue Apr 30, 2018 · 1 comment · Fixed by #4064 or GulajavaMinistudio/jquery#51
Assignees
@mgol
Labels
Bug CSS Has Pull Request
Milestone
3.4.0

Comments

@mgol
Copy link
Member

mgol commented Apr 30, 2018

Description

jQuery shouldn't auto-append "px" to CSS variables.:

div.css( "--a", 3 ).css( "--a" ); // is: "3px", should be: "3"

Link to test case

https://jsfiddle.net/uxj3znv0/
@mgol mgol added this to the 3.4.0 milestone Apr 30, 2018
@mgol mgol self-assigned this Apr 30, 2018
mgol added a commit to mgol/jquery that referenced this issue Apr 30, 2018
@mgol
CSS: Don't auto-append "px" to CSS variables
22ac6dc 
Fixes jquerygh-4063
@mgol mgol mentioned this issue Apr 30, 2018
Merged
3 tasks
@mgol
Copy link
Member Author

mgol commented Apr 30, 2018

PR: #4064

mgol added a commit to mgol/jquery that referenced this issue May 2, 2018
@mgol
CSS: Don't auto-append "px" to CSS variables
5fc77d1 
Fixes jquerygh-4063
@mgol mgol closed this as completed in #4064 Jun 4, 2018
mgol added a commit that referenced this issue Jun 4, 2018
@mgol
CSS: Don't auto-append "px" to CSS variables (#4064)
75b77b4 
Fixes gh-4063
Closes gh-4064
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Jun 6, 2018
Merged
4 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Bug CSS Has Pull Request
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

CSS: Don't auto-append "px" to CSS variables mgol/jquery
Update upstream jquery/jquery
1 participant
@mgol