Permalink
Show file tree
Hide file tree
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Make sure that the removeEvent and buildFragment private functions ar…
…e exposed (to help with access across modules). The final API for each of these is very much in flux and will likely change before the final release. Fixes #7011.
- Loading branch information
Showing
4 changed files
with
8 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -134,7 +134,7 @@ | ||
|
||
// release memory in IE | ||
root = script = div = all = a = null; | ||
})(); | ||
})( jQuery ); | ||
|
||
jQuery.props = { | ||
"for": "htmlFor", | ||
acb162a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be interested in what you decide for a name. My current name for it is
fuse.dom.getFragmentFromHTML()
, it's not really intended for public API use but it does sit exposed. I am totally open to suggestions, although mine returns a fragment or a single element so ya naming is hard :Pacb162a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how much losing private variables will hurt minification like
undefined
andwindow
and all those. Maybe when loaded as modules minification is less important as it's separate smaller chunks. I know @getify is doing a lot of research in that area and has produced results that suggest separate minified files severed up is faster than 1 minified file.