Relative percentage values (+= / -=) work in .animate but not in .css

[mgol]

Originally reported by jwagner: http://bugs.jquery.com/ticket/14484

.css({'left':'+=50%'})

...moves the item by 50 pixel instead of 50%, while

.animate({'left':'+=50%'})

...works as expected (adds 50%).

The docs suggest that .css and .animate should behave identically ( http://api.jquery.com/css/):

As of jQuery 1.6, .css() accepts relative values similar to .animate().

If "similar" should really mean "similar" but not identical, it would help to give a hint in the docs that relative percentage values are not supported by .css.

The problem shows up in current Chrome, Firefox and IE10.

Fiddle to reproduce: http://jsfiddle.net/2VGgg/

[mgol]

Original discussion:

Changed 12 months ago by timmywil

Priority changed from undecided to blocker
Status changed from new to open
Component changed from unfiled to css
Milestone changed from None to 1.11/2.1
This looks valid.

comment:2 in reply to: ↑ description Changed 11 months ago by francomalatacca

Replying to jwagner@…:

.css({'left':'+=50%'})

The problem is that style function that is called by css function doesn't care about percentage. A fix could be by adding support for this by checking if there is the % symbol at the end of value. If so it should compute the percentage of the parent width. I fixed the bug with something

        if ( type === "string" && (ret = rrelNum.exec( value )) ) {
            // Fixes bug #14484
            if(!/[%$]/i.exec(value) ) {
                value = (( ret[1] + 1 ) *  ret[2]) + parseFloat( jQuery.css( elem, name ) );
            } else {
                value = parseFloat( jQuery.css( elem, name ) ) + (parseFloat(jQuery(elem).parent().css("width")) * (( ret[1] + 1 ) * ret[2]/100));
            }

            // Fixes bug #9237
            type = "number";
        }

Thanks. Franco

comment:3 Changed 10 months ago by gibson042

Owner set to gibson042
Status changed from open to assigned
comment:4 Changed 8 months ago by gibson042

Milestone changed from 1.11/2.1 to 1.11.1/2.1.1
comment:5 Changed 6 months ago by anonymous

This is reproducible for other unit "em"

There are other not so popular units like "cm","in" etc.

Need fix for them too

comment:6 Changed 6 months ago by dmethvin

Milestone changed from 1.11.1/2.1.1 to 1.12/2.2

[dmethvin]

@gibson042 can you get to this soon?