Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css vendor prefix error #2015

Closed
pltnkv opened this issue Jan 16, 2015 · 3 comments
Closed

css vendor prefix error #2015

pltnkv opened this issue Jan 16, 2015 · 3 comments
Assignees
@mgol
Labels
Bug CSS
Milestone
1.12.0/2.2.0

Comments

@pltnkv
Copy link

pltnkv commented Jan 16, 2015 •
edited by mgol
Loading

$().css automatically adds vendor prefixes, but if firstly calls $().css function with prefixes styles, auto-adding break. Run example in Safari
http://jsfiddle.net/8cf0hyhj/
@dmethvin
Copy link
Member

Yes, trying this on Safari 8 via Browserstack I agree it's failing. The problem seems to be that if you explicitly set the vendor-prefixed property on a style then Safari starts responding to that property on any CSSStyleDeclaration. Totally bizarre. Can someone else verify they see this happening in vendorPropName() as well?

I don't know that this is something we can fix. Is there a reason you just don't let us do the prefixes for you?

@mgol
Copy link
Member

mgol commented Jan 21, 2015

This bug is caused by:

jquery/src/css.js

Line 265 in 740e190

( jQuery.cssProps[ origName ] = vendorPropName( style, origName ) );

If we find neither the original style property nor a prefixed one, we return the original one from vendorPropName(). This is then saved to jQuery.cssProps[propertyName] in the line linked above. The first .css setter checks for msTransform first and since Safari recognizes neither msTransform, msMsTransform, webkitMsTransform nor mozMsTransform, jQuery.cssProps.transform is saved to be "msTransform".

Later when we try to set transform to something, we have it cached that it maps to msTransform which obviously won't work.

We should fix it.

@mgol mgol added this to the 3.0.0 milestone Jan 21, 2015
@mgol mgol self-assigned this Apr 26, 2015
mgol added a commit to mgol/jquery that referenced this issue May 11, 2015
@mgol
CSS: Don't cache unrecognized CSS property names
72b3005 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "mozTransition", "all 1s" );

should not prevent one from from later setting the transition directly:

	elem.css( "transition", "all 1s" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transition.

Fixes jquerygh-2015
@mgol mgol mentioned this issue May 11, 2015
Closed
mgol added a commit to mgol/jquery that referenced this issue May 11, 2015
@mgol
CSS: Don't cache unrecognized CSS property names
3e0a2db 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

Fixes jquerygh-2015
mgol added a commit to mgol/jquery that referenced this issue May 11, 2015
@mgol
CSS: Don't cache unrecognized CSS property names
e816e94 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

Fixes jquerygh-2015
@mgol
Copy link
Member

mgol commented May 11, 2015

PR: #2298

mgol added a commit to mgol/jquery that referenced this issue May 12, 2015
@mgol
CSS: Don't cache unrecognized CSS property names
de39b88 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

Fixes jquerygh-2015
mgol added a commit to mgol/jquery that referenced this issue May 12, 2015
@mgol
CSS: Don't cache unrecognized CSS property names
25ca2a4 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

Fixes jquerygh-2015
mgol added a commit to mgol/jquery that referenced this issue May 19, 2015
@mgol
CSS: Don't cache unrecognized CSS property names
6da90d9 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

Fixes jquerygh-2015
@mgol mgol closed this as completed in d471842 Jun 1, 2015
mgol added a commit that referenced this issue Jun 1, 2015
@mgol
CSS: Don't cache unrecognized CSS property names
42ea746 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

(cherry-picked from d471842)

Fixes gh-2015
Closes gh-2298
@mgol mgol mentioned this issue Jul 21, 2015
Closed
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
CSS: Don't cache unrecognized CSS property names
833e291 
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

Fixes gh-2015
Closes gh-2298
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Bug CSS
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

CSS: Don't cache unrecognized CSS property names mgol/jquery
4 participants
@dmethvin @timmywil @pltnkv @mgol