Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for new ES6 Symbol entity #2645

Closed
markelog opened this issue Oct 13, 2015 · 0 comments
Closed

Add tests for new ES6 Symbol entity #2645

markelog opened this issue Oct 13, 2015 · 0 comments
Assignees
@mgol
Milestone
1.12.0/2.2.0

Comments

@markelog
Copy link
Member

At least for jQuery.isPlainObject, jQuery.isEmptyObject, jQuery.isNumeric.

Which may, or may not include tests for the shimmed Symbol.

See #2627 discussion for more.
@timmywil timmywil modified the milestone: 3.0.0 Oct 16, 2015
LizaLemons added a commit to LizaLemons/jquery that referenced this issue Oct 17, 2015
@LizaLemons
Core: make isNumeric test work on Symbol
37ccf82 
Ref jquery#2645
@LizaLemons LizaLemons mentioned this issue Oct 17, 2015
Closed
LizaLemons added a commit to LizaLemons/jquery that referenced this issue Oct 17, 2015
@LizaLemons
Core: make isNumeric test work on Symbol
48c2735 
Ref jquery#2645
LizaLemons added a commit to LizaLemons/jquery that referenced this issue Oct 17, 2015
@LizaLemons
Core: make isNumeric test work on Symbol
83323f1 
Ref jquery#2645
markelog pushed a commit that referenced this issue Oct 17, 2015
@LizaLemons @markelog
Core: make isNumeric test work on Symbol
0703fd5 
Ref #2645
Closes #2657
LizaLemons added a commit to LizaLemons/jquery that referenced this issue Oct 18, 2015
@LizaLemons
Core: add unit test for isPlainObject(Symbol)
5aaaf1e 
Fixes jquery#2645
@LizaLemons LizaLemons mentioned this issue Oct 18, 2015
Closed
dmethvin pushed a commit that referenced this issue Oct 18, 2015
@LizaLemons @dmethvin
Core: add unit test for isPlainObject(Symbol)
d3a2fdc 
Fixes #2645
Closes #2661
(cherry picked from commit 9090d98)
gibson042 pushed a commit that referenced this issue Oct 25, 2015
@LizaLemons @gibson042
Core: make isNumeric test work on Symbol
d846c25 
Ref #2645
Closes #2657

(cherry picked from commit 0703fd5)
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 8, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
None yet
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
4 participants
@dmethvin @timmywil @markelog @mgol