Skip to content

Fix #13353; #13428; #14359: Better treatment of native-backed events (focus/blur/checkbox-click) #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gibson042
Copy link
Member

It's big, but much better than gibson042@80789b1... and this brings the count of fixed bugs up to 3, further reducing the added size per fix! 😉

At any rate, I also found some possible optimizations in event.js that I'll be exploring once this PR closes either way.

raw gz Compared to 1.x-master @ fd29642

 +2073   +586 dist/jquery.js
  +484   +103 dist/jquery.min.js

@dmethvin
Copy link
Member

I have a theory that the people who use the data parameter, or who use a namespace for manually triggering, could just go through the old-style path rather than using a natively triggered event method. That's what they did until I tried to fix it a few versions back. I just can't imagine that fixing these specific cases is worth 484 bytes gzip.

@gibson042
Copy link
Member Author

Don't you mean +103? Anyway, you may be right but I don't know how to confirm... it just rubs me the wrong way that we went to so much trouble fixing these events in particular to match native behavior and ended up breaking our own internal consistency.

@gibson042
Copy link
Member Author

The size of this fix would likely be reduced by the ideas in http://bugs.jquery.com/ticket/12031#comment:9 as well.

@dmethvin
Copy link
Member

Closing until we get the implementation in http://bugs.jquery.com/ticket/12031 done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants