$.holdReady is broken in 3.2.0

[San4es]

The "$.holdReady is not a function" error occurs after the update to jQuery 3.2.0.

To reproduce the issue, see https://jsfiddle.net/4ocpkd69/ (see browser console) and compare results with jQuery 3.1.1 in https://jsfiddle.net/4ocpkd69/1/

[mgol]

It was moved erroneously to jQuery.fn.holdReady in bd984f0. Marking as a blocker for 3.2.1.

Thanks for the report!

[mgol]

This only shows we should have explicit tests for any API that we deprecate, even if there weren't any due to legacy reasons.

[timmywil]

Oof. How did we not catch this?

By the way, temporary workaround:

jQuery.holdReady = jQuery.fn.holdReady;

[timmywil]

I think making the necessary adjustments to this PR and landing it will give us the test coverage we want for this issue.

[Krinkle]

It had been failing for several weeks in Jenkins/TestSwarm:
http://swarm.jquery.org/project/jquerymigrate

Core commit (17 February):

• bd984f0 Core: Move holdReady to deprecated

[timmywil]

Well, that's jQuery migrate, not jQuery core, but I'm surprised no one said anything.

[mgol]

Perhaps looking at Migrate test results should be added to the release instructions in our Wiki. Currently only regular Core & periodic test results are mentioned. -- Michał Gołębiowski

[timmywil]

This seems like a rare case, and it will be fixed when we land the PR I mentioned. I would like to ensure that reviewing core tests is sufficient for releasing core and reviewing migrate tests sufficient for migrate.