Support angular 4 #404
Merged
Support angular 4 #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
reviewed
Mar 20, 2017
package.json
Outdated
| "devDependencies": { | ||
| "devextreme": "~16.2.4", | ||
| "jquery": "^2.0.0 || ^3.0.0", | ||
| "jquery": "^2.0.0 || ~3.1.1", |
Contributor
There was a problem hiding this comment.
Remove this unnecessary dev dependency
package.json
Outdated
| "@types/jquery": "^2.0.0 || ^3.0.0", | ||
| "jquery": "^2.0.0 || ^3.0.0" | ||
| "@types/jquery": "^2.0.0 || ~3.1.1", | ||
| "jquery": "^2.0.0 || ~3.1.1" |
Contributor
There was a problem hiding this comment.
Seems that "2.0.0 - 3.1" is more suitable version specification
Contributor
There was a problem hiding this comment.
Why do we need these changes?
Contributor
Author
There was a problem hiding this comment.
@GoshaFighten These changes fixed issue #406
Contributor
There was a problem hiding this comment.
Yes, but we will be stuck to jQuery 3.1.1. jQuery is going to fix the issue in $.holdReady is broken in 3.2.0, plus we are going fix it in our code in the DevExtreme fails with the "$.holdReady is not a function" error when jQuery 3.2.0 is used bug report.
Aden-git
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.