Core: fix holdReady and move readywait to an iframe test #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timmywil
changed the title
4 tasks
|
Will land today. Get your reviews in! Thanks. |
timmywil
force-pushed
the
readywait
branch
2 times, most recently
from
1b0defa
to
d1558cd
Compare
mgol
requested changes
Mar 18, 2017
test/unit/readywait.js
Outdated
| @@ -0,0 +1,12 @@ | |||
| var start = new Date(); | |||
There was a problem hiding this comment.
What's the purpose of this file? It runs the same test as one in test/unit/ready and it's not used anywhere, this looks like dead code.
There was a problem hiding this comment.
Indeed. I thought I deleted it.
mgol
approved these changes
Mar 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close gh-3331
Fixes gh-3573
Summary
I've edited @stevemao's PR, made the recommended changes, and fixed the issue with
jQuery.holdReady. I confirmed that the test failed before movingholdReadyback to its proper place.Checklist