Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Test: Assert that removeClass(undefined) is chainable. #1008

wants to merge 1 commit into


None yet
2 participants

Krinkle commented Oct 25, 2012

Follows-up 227c49a / gh-913.

Assert that the return value is strictEqual to $div. That way it doesn't just assert it being a harmless (e.g. that undefined doesn't mean "remove all classes", but "do nothing"), but also that it is still chainable.



Krinkle commented Oct 25, 2012

On second thought, it may not be as useful to assert. I was confusing the argument.length logic with methods that are getter or setter depending on that logic (which previously used a false-y or undefined check). However in the case of removeClass this is different since it is always chainable.


dmethvin commented Oct 29, 2012

True, it's not a getter/setter. I think I'll leave it out then.

@dmethvin dmethvin closed this Oct 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment