Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Grunt 0.4, and Uglify2 with Source Maps! #1092

Merged
merged 1 commit into from
Dec 19, 2012
Merged

Update to Grunt 0.4, and Uglify2 with Source Maps! #1092

merged 1 commit into from
Dec 19, 2012

Conversation

mikesherov
Copy link
Member

No description provided.

Krinkle
Krinkle reviewed Dec 19, 2012
View reviewed changes
Gruntfile.js
var data = {};
try {
data = grunt.file.readJSON( filepath );
grunt.verbose.write( "Reading " + filepath + "..." ).ok();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik grunt.file.read does this verbose logging already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dmethvin
Copy link
Member

Running into issues with npm install on Windows 7, possibly related to lodash. lodash/lodash#139

@dmethvin
Copy link
Member

Yay, now working on Windows! Wasn't lodash fault in particular, my system's split personality wasn't aligned between the Windows half and the Unix half.

This will require everyone to npm install again, and it will be kind of a pain to switch between the two if you need the old stuff, so I wanted to give a heads-up before pushing it and see if there are any issues to consider.

@scottgonzalez
Copy link
Member

This will require everyone to npm install again, and it will be kind of a pain to switch between the two if you need the old stuff, so I wanted to give a heads-up before pushing it and see if there are any issues to consider.

I suppose running a bisect across major grunt versions might not be as bad as bisects that go back into the days of make...

@scottgonzalez
Copy link
Member

Except of course for all the damn version ranges that are going to be wrong...

@dmethvin
Copy link
Member

Right, I pushed up a fix today on principle, but if you bisect it won't likely run. Let's make a blood pact to banish > from the devDependencies section.

@mikesherov mikesherov merged commit cc97125 into jquery:master Dec 19, 2012
@mikesherov mikesherov deleted the grunt4 branch December 19, 2012 23:40
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikesherov @dmethvin @scottgonzalez @Krinkle