New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUnit 1.16 #1654
QUnit 1.16 #1654
Conversation
Hey Leo, ping me out when you release new QUnit and i will land this right after. |
@leobalter is it safe to go with 1.16 now? |
I'll run a last test before confirming. |
Done.
|
On a further investigation I've found 286c4d9 mentioning the jenkins/testswarm issue. Even though, I would like to use npmcopy not in a so manual and misleading way as it is without @e7c7fa9, but with the mentioned issue, we might have to drop it as well. |
Since @gibson042 already updated QUnit i wonder if these changes are still relevant. P.S. a little more communication with each other would be good, so we wouldn't step on each other toes next time |
Ack! I had actually been following this PR, but for some reason totally blanked and thought it was for another repo. I'm very sorry. That said, 6748ba3 is a simple and naïve upgrade that readily admits its own faults. Some of those are addressed here, and these changes are very much still relevant. |
at least QUnit 1.16 is not causing any regression issues. I am closing this, maybe you might like to try @e7c7fa9 as a single commit. |
QUnit will be released very soon, and I'll update this PR along.
Also tested with the 1.16 RC.
cc @markelog