Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUnit 1.16 #1654

Closed
wants to merge 3 commits into from
Closed

QUnit 1.16 #1654

wants to merge 3 commits into from

Conversation

leobalter
Copy link
Member

QUnit will be released very soon, and I'll update this PR along.

Also tested with the 1.16 RC.

cc @markelog

@markelog
Copy link
Member

Hey Leo, ping me out when you release new QUnit and i will land this right after.

@dmethvin
Copy link
Member

dmethvin commented Dec 4, 2014

@leobalter is it safe to go with 1.16 now?

@leobalter
Copy link
Member Author

I'll run a last test before confirming.

@leobalter leobalter changed the title [WIP] QUnit 1.16 QUnit 1.16 Dec 4, 2014
@leobalter
Copy link
Member Author

Done.

  • @e7c7fa9 is there for convenience
  • @67ce239 might be ignored and not merged, but is recommended.

@leobalter
Copy link
Member Author

On a further investigation I've found 286c4d9 mentioning the jenkins/testswarm issue.

Even though, I would like to use npmcopy not in a so manual and misleading way as it is without @e7c7fa9, but with the mentioned issue, we might have to drop it as well.

@markelog
Copy link
Member

markelog commented Dec 7, 2014

Since @gibson042 already updated QUnit i wonder if these changes are still relevant.

P.S. a little more communication with each other would be good, so we wouldn't step on each other toes next time

@gibson042
Copy link
Member

Ack! I had actually been following this PR, but for some reason totally blanked and thought it was for another repo. I'm very sorry.

That said, 6748ba3 is a simple and naïve upgrade that readily admits its own faults. Some of those are addressed here, and these changes are very much still relevant.

@leobalter
Copy link
Member Author

at least QUnit 1.16 is not causing any regression issues.

I am closing this, maybe you might like to try @e7c7fa9 as a single commit.

@leobalter leobalter closed this Dec 8, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants