-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds minimal license header block for jquery.min.js #443
Conversation
This looks good except the date timestamp in the min file doesn't match the one in the non-min file. |
Yeah, I was trying to get as close as possible without writing any kind of string manipulation. What do you think? Will people take issue? |
I think they should match as it's a good check of what you've got along with version num. Having them differ does no good and has the potential to make someone suspect they're not identical. |
Oh, I see what you mean - not the format, but the actual time stamp value itself. |
Richard, updated with matching dates now |
Looks great :) |
Haha, Glad you like it |
/*! jQuery v@VERSION http://jquery.com/ | http://jquery.org/license */ Perfect. |
Builds minimal license header block for jquery.min.js
Builds minimal license header block for jquery.min.js
So this shed.. it's a few months old.. a decent color --truly decent!-- but i got some ideas on how it cool look even better...
And really, this isn't about bytes for me.. just that the scheme is ugly and there's no functional need for it to be there. |
@paulirish +1 Makes sense, now that I think about it… Everyone who knows how to view the jQuery source would probably recognize a scheme-less URL. Also… BYTESSSS |
Per jQuery Bugs Team discussion