Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds minimal license header block for jquery.min.js #443

Merged
merged 3 commits into from
Aug 4, 2011

Conversation

rwaldron
Copy link
Member

Per jQuery Bugs Team discussion

@rdworth
Copy link
Contributor

rdworth commented Jul 23, 2011

This looks good except the date timestamp in the min file doesn't match the one in the non-min file.

@rwaldron
Copy link
Member Author

Yeah, I was trying to get as close as possible without writing any kind of string manipulation. What do you think? Will people take issue?

@rdworth
Copy link
Contributor

rdworth commented Jul 23, 2011

I think they should match as it's a good check of what you've got along with version num. Having them differ does no good and has the potential to make someone suspect they're not identical.

@rwaldron
Copy link
Member Author

Oh, I see what you mean - not the format, but the actual time stamp value itself.

@rwaldron
Copy link
Member Author

Richard, updated with matching dates now

@rdworth
Copy link
Contributor

rdworth commented Jul 24, 2011

Looks great :)

@rwaldron
Copy link
Member Author

Haha, Glad you like it

@mathiasbynens
Copy link
Contributor

/*! jQuery v@VERSION http://jquery.com/ | http://jquery.org/license */

Perfect.

dmethvin added a commit that referenced this pull request Aug 4, 2011
Builds minimal license header block for jquery.min.js
@dmethvin dmethvin merged commit 566f958 into jquery:master Aug 4, 2011
markelog pushed a commit to markelog/jquery that referenced this pull request Aug 9, 2011
Builds minimal license header block for jquery.min.js
@paulirish
Copy link
Member

So this shed.. it's a few months old.. a decent color --truly decent!-- but i got some ideas on how it cool look even better...

/*! jQuery v@VERSION http://jquery.com/ | http://jquery.org/license */

                                 ↓↓↓↓↓↓↓↓↓↓↓↓

/*! jQuery v@VERSION jquery.com | jquery.org/license */

And really, this isn't about bytes for me.. just that the scheme is ugly and there's no functional need for it to be there.

@mathiasbynens
Copy link
Contributor

@paulirish +1 Makes sense, now that I think about it… Everyone who knows how to view the jQuery source would probably recognize a scheme-less URL.

Also… BYTESSSS

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants