CSS fixes rollup: fixes #10796 and fixes #10639 #616
Conversation
| style = elem.style; | ||
| width = style.width; | ||
| style.width = name === "fontSize" ? "1em" : ( ret || 0 ); | ||
| ret = computedStyle.getPropertyValue("width") + "px"; |
There was a problem hiding this comment.
Nice to see the new style guide changes folding in. As soon as the JSHint updates are rolled in I will have a full update of the change
…F PX IN WEBKIT it does this by creating an awesome hack like Dean Edwards
also, removed an unnecessary check in dean edwards hack
|
So, the perf is available here: http://jsperf.com/jquery-10693 It's VERY slow, but I don't see another way to get this to be faster. I tried using At this point, it's a matter of speed vs. maintainability vs. size vs. correctness... I'd love some further comments and criticisms on this. Thanks! |
|
expando turf is a dark road, I recommend exhausting your options |
|
I believe they're all exhausted unfortunately. |
| @@ -277,6 +278,11 @@ jQuery.support = (function() { | |||
| offsetSupport.subtractsBorderForOverflowNotVisible = ( inner.offsetTop === -5 ); | |||
| offsetSupport.doesNotIncludeMarginInBodyOffset = ( body.offsetTop !== conMarginTop ); | |||
|
|
|||
| if( window.getComputedStyle ) { | |||
|
Landed. 7f6a991 |
fixes bug when margin is in percentage Re metafizzy/isotope#119 All the hard work done by @mikesherov http://bugs.jquery.com/ticket/10639 jquery/jquery#616
So I submitted a separate PR for #10796, but I needed the change from there to effectively fix #10639 So I created a PR with both changes.
If you take this one in, please ignore #610.
If you take #610, you can always take this one later!