Selector: Make selector lists work with qSA again
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sizzle 2.3.7 started using `CSS.supports( "selector(SELECTOR)" )` before using `querySelectorAll` on the selector. This was to solve jquery/jquery#5098 - some selectors, like `:has()`, now had their parameters parsed in a forgiving way, meaning that `:has(:fakepseudo)` no longer throws but just returns 0 results, breaking that Sizzle mechanism. A recent spec change made `CSS.supports( "selector(SELECTOR)" )` always use non-forgiving parsing, allowing us to use this API for what we've used `try-catch` before. To solve the issue on the spec side for older jQuery versions, `:has()` parameters are no longer using forgiving parsing in the latest spec update but our new mechanism is more future-proof anyway. However, the Sizzle implementation has a bug - in `CSS.supports( "selector(SELECTOR)" )`, `SELECTOR` needs to be a `<complex-selector>` and not a `<complex-selector-list>`. Which means that selector lists now skip `qSA` and go to the Sizzle custom traversal: ```js CSS.supports("selector(div:valid, span)"); // false CSS.supports("selector(div:valid)"); // true CSS.supports("selector(span)"); // true ``` To solve this, this commit wraps the selector list passed to `CSS.supports( "selector(:is(SELECTOR))" )` with `:is`, making it a single selector again. See: * https://w3c.github.io/csswg-drafts/css-conditional-4/#at-supports-ext * https://w3c.github.io/csswg-drafts/selectors-4/#typedef-complex-selector * https://w3c.github.io/csswg-drafts/selectors-4/#typedef-complex-selector-list Fixes jquery/jquery#5177 Ref w3c/csswg-drafts#7280
mgol
force-pushed
the
supports-selector-list-fix-jq-5177
branch
from
4ba83c9
to
48b0c88
Compare
gibson042
approved these changes
Dec 19, 2022
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sizzle 2.3.7 started using
CSS.supports( "selector(SELECTOR)" )before usingquerySelectorAllon the selector. This was to solve jquery/jquery#5098 - some selectors, like:has(), now had their parameters parsed in a forgiving way, meaning that:has(:fakepseudo)no longer throws but just returns 0 results, breaking that Sizzle mechanism.A recent spec change made
CSS.supports( "selector(SELECTOR)" )always use non-forgiving parsing, allowing us to use this API for what we've usedtry-catchbefore.To solve the issue on the spec side for older jQuery versions,
:has()parameters are no longer using forgiving parsing in the latest spec update but our new mechanism is more future-proof anyway.However, the Sizzle implementation has a bug - in
CSS.supports( "selector(SELECTOR)" ),SELECTORneeds to be a<complex-selector>and not a<complex-selector-list>. Which means that selector lists now skipqSAand go to the Sizzle custom traversal:To solve this, this commit wraps the selector list passed to
CSS.supports( "selector(:is(SELECTOR))" )with:is, making it a single selector again.See:
Fixes jquery/jquery#5177
Ref w3c/csswg-drafts#7280
+2 bytes