Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UniqueElements annotation for Extensions #466

Closed
jlink opened this issue Mar 11, 2023 · 1 comment
Closed

Support UniqueElements annotation for Extensions #466

jlink opened this issue Mar 11, 2023 · 1 comment
Labels
cleanup enhancement

Comments

@jlink
Copy link
Collaborator

jlink commented Mar 11, 2023

Testing Problem

Extensions (eg jqwik-vavr have to add their own configurator if they want to support @UniqueElements for custom-made arbitraries. Allow extensions to use the existing UniqueElementsConfigurator.

Suggested Solution

This could be done by introducing an interface for Arbitrary.uniqueElements(..) eg Uniquable.

Discussion

Alternative implementation: Add the method to StreamableArbitrary. But currently, not all subtypes support unique elements.
jlink added a commit that referenced this issue Mar 16, 2023
@jlink
Add uniqueElements() methods to StreamableArbitrary interface
15f6067 
See #466
@jlink
Copy link
Collaborator Author

jlink commented Mar 16, 2023

Implemented in 15f6067

@jlink jlink closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlink