This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Add cooldown functionality to scaling policies and storage backend. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
added
area/scaling
Sherpa policies now allow the specifying of a cooldown as a time duration in seconds. When a scaling activity is requested, the cooldown is checked against the last scaling event for the job group. If the last event has occurred within the cooldown period, the scaling request will be denied. Closes #49
|
Hi @jrasell the corresponding meta is missing. Is it on purpose ? |
|
@commarla could you elaborate on what you mean? |
|
@jrasell maybe I missed it but I didn't see the corresponding nomad meta for the cooldown feature in your pr. |
|
@commarla oh yeah, good shout. I have to fix up the conflicts when I get time so i'll address that also. Thanks a lot for your help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sherpa policies now allow the specifying of a cooldown as a time
duration in seconds. When a scaling activity is requested, the
cooldown is checked against the last scaling event for the job
group. If the last event has occurred within the cooldown period,
the scaling request will be denied.
Closes #49