Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New field: IMDb Number of Votes #29

Closed
kkayacan opened this issue Feb 8, 2018 · 4 comments
Closed

New field: IMDb Number of Votes #29

kkayacan opened this issue Feb 8, 2018 · 4 comments

Comments

@kkayacan
Copy link
Contributor

kkayacan commented Feb 8, 2018

I like sorting movies by number of votes on IMDb so a new sortable field would be great. I believe imdphp library already supports this data. If you advise where to look, I can try to add this.

  /**
   * Return number of votes for this movie
   * @method votes
   * @return int
   * @see IMDB page / (TitlePage)
   */
  public function votes() {
    if ($this->main_votes == -1) $this->rate_vote();
    return $this->main_votes;
  }
@jreklund
Copy link
Owner

jreklund commented Feb 8, 2018

I think this is everywhere. Should take a half hour if you know the code. xD

/install/sql/update-3.7.sql
New file needed, votes added after rating. Don't know how many votes there are, but an int 8 unsigned should be enough.
/config/version.default.inc.php
Db version into 3.7 and normal version bump for installation script to be able to run
/includes/export.inc.php
Export the new value (votes)
/includes/movie.search.inc.php
Adding it as a new $sortoptions
/lang/*
Translate the new "votes asc" and "votes desc" string.
/lib/db/Movie.class.php
Adding it to fill()
/template/default/movies/update.html
Update form, also add it after rating.
The name="" should be votes, and that should be the same everywhere.
There are an option to validate for only numbers, don't know it by heart.
/template/default/movies/movie.html
Displaying the value in the movie / tv-show page

@kkayacan
Copy link
Contributor Author

kkayacan commented Feb 8, 2018

Thanks. I'll try at weekend.

@kkayacan
Copy link
Contributor Author

kkayacan commented Feb 10, 2018

Changes work for me, thank you very much. Shall I create a pull request (never done that before) or will you do it yourself at next release?

@jreklund
Copy link
Owner

If you wan't credit for it make a pull request and I will look over your code. Or I will do it myself after I'm finished with another wanted feature.

jreklund pushed a commit that referenced this issue Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants