Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not build with Node 10+ and no title bar #13

Closed
chhh opened this issue May 2, 2018 · 0 comments
Closed

Does not build with Node 10+ and no title bar #13

chhh opened this issue May 2, 2018 · 0 comments
Assignees
@jreznot
Labels
bug fixed

Comments

@chhh
Copy link

chhh commented May 2, 2018

An error in electron-packager's cli.js stops the build process (electron/packager#831)

If I manually fix the issue in that js file, it compiles (with gradlew bundleApp), but when the app starts there's no title bar.
@jreznot jreznot added the bug label May 8, 2018
jreznot pushed a commit that referenced this issue Apr 19, 2019
Update Node and Electron dependencies #13
a454e55
@jreznot jreznot self-assigned this Apr 19, 2019
@jreznot jreznot added the fixed label Apr 19, 2019
@jreznot jreznot closed this as completed Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jreznot jreznot

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chhh @jreznot