Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Upgrade to React 18 #27

Closed
conversun opened this issue Jun 13, 2022 · 7 comments · Fixed by #33
Closed

Upgrade to React 18 #27

conversun opened this issue Jun 13, 2022 · 7 comments · Fixed by #33

Comments

@conversun
Copy link

image

@ebukaodini
Copy link

Hi @jrgarciadev
I got this error while deploying to netlify. I'm using "react-iconly": "^2.2.5",

image

@ayoubphy
Copy link

Is there any progress on this issue ?

@A1yks
Copy link

A1yks commented Aug 29, 2022

Is there any progress on this issue ?

You can install this module with --force flag. After that you need to create a file react-iconly.d.ts with the following contents:

import { ReactNode } from 'react';

declare module 'react-iconly' {
    export interface IconProps {
        children?: ReactNode;
    }
}

And don't forget to include this file in your tsconfig.json

@SalahAdDin
Copy link

@jrgarciadev man?

@6km
Copy link

6km commented Feb 18, 2023

@jrgarciadev can you please give some attention to this issue?

@jrgarciadev
Copy link
Owner

Sorry guys but currently I'm focused on the NextUI migration to TailwindCSS so I have no time for updating this library at the moment, if any of you want to send a PR migrating it to React 18 it will be appreciated 🙏🏻

@SalahAdDin
Copy link

Sorry guys but currently I'm focused on the NextUI migration to TailwindCSS so I have no time for updating this library at the moment, if any of you want to send a PR migrating it to React 18 it will be appreciated 🙏🏻

I think you have no access to the last icons, right? In that case, we can't add more icons I think.

ionleu added a commit to ionleu/react-iconly that referenced this issue Mar 23, 2023
@jrgarciadev jrgarciadev linked a pull request Mar 24, 2023 that will close this issue
jrgarciadev added a commit that referenced this issue Mar 24, 2023
Bugfix #27 and #32: Upgrade to React 18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants