-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result passing property added for other projects. #316
Conversation
if self._has_module(CTP515): | ||
result["CTP515"] = self.ctp515.results_dict | ||
if self._has_module(CTP528CP504): | ||
result["CTP528"] = self.ctp528.result_dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here
Corrected: If indeed this is what you want, you'll need to add unit tests (probably here) or per-phantom (probably here) and update the docs (I'd put it in the "view the results" section here. |
Yes, I do intend to support all phantoms in the same way, creating a unified consistent jsonable object for any cbct analysis. Will amend this pull request as I have time. |
Good news on this front. I'm working on adding integration via APIs, so a dict of results (converted to JSON) can be helpful here. I'll tackle this once I can unify the workflow. |
Closed in #360 |
RAM-3108 Fix order of text in PDF to match images Approved-by: Randy Taylor
The intent of this patch is to create a easy to maintain self building dictionary, that can be called by external classes or frameworks.
Basic format would be:
I.e.
would store the analyzed measure for the air volume of the CTP404 module.
At all points the indices would be human readable, and for modules with more or less roi's then the function could be redefined from the inherited module.
Documentation of the human readable names would have to be added to the readthedocs of course.